gasanchez10 / iaforsoftlab1

0 stars 0 forks source link

Lab 1 feedback #1

Open jsrc1115 opened 1 month ago

jsrc1115 commented 1 month ago

API KEY IN THE REPO

  1. Remember in general and more in an academic setting to include the sources of your information. (7 points)

  2. (10 points)

  3. (15 points) Missing CoT, the prompt chain you specified is actually a CoT, prompt chain is something like this:

    
    response = model.generate_content(
    "Can you give me a list of the most popular places in Colombia?, please include only the list as bullet points no extra text."
    )
    print(response.text)

chain_node_1_response = model.generate_content( f""" Can you add a description to each of the places in this list? {response.text} """ ) print(chain_node_1_response.text)


I'm going to accept the prompt_chain as de CoT prompt, but the Generated Knowledge Prompting it's not correct, you are just asking the last prompt the example did, not the whole process explained in the article: https://www.promptingguide.ai/techniques/knowledge 

4. (15 points) Quoting the lab "document any prompts/outputs" you didn't document LLM prompts and responses.

5. (20 points) 
Recommendation: You did not have to create 1 file for each endpoint you could have created the 2 endpoints in the same file.
The idea was to use the LLM to do the summarization giving partial credit.

7 + 10 + 15 + 15 + 20 = 67
jsrc1115 commented 1 month ago

You have you API key in you repository. I didn't remove any points for that but that is a security risk on an actual project.

gasanchez10 commented 1 month ago

Hi Teacher. Just pushed the second lab into the same repo. Best,

German

Enviado desde Outlook para iOShttps://aka.ms/o0ukef


De: jsrc1115 @.> Enviado: Thursday, July 18, 2024 12:15:07 PM Para: gasanchez10/iaforsoftlab1 @.> Cc: Subscribed @.***> Asunto: Re: [gasanchez10/iaforsoftlab1] Lab 1 feedback (Issue #1)

You have you API key in you repository. I didn't remove any points for that but that is a security risk on an actual project.

— Reply to this email directly, view it on GitHubhttps://github.com/gasanchez10/iaforsoftlab1/issues/1#issuecomment-2237109098, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIPVBPXZUAKO5ZVOFB63A5TZM7ZZXAVCNFSM6AAAAABLDC7MVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXGEYDSMBZHA. You are receiving this because you are subscribed to this thread.Message ID: @.***>