gaston-alma / munki

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

MWA: manifests list should ignore .AppleDouble #226

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Share the munki repository via netatalk from a Linux server for access by 
admin workstation.
2. Access files in the mounted volume creates .AppleDouble folders with 
non-existant resource fork information.
3. Look at manifests list in MWA and it shows the real manifests as well as the 
.AppleDouble files as well.

What is the expected output? What do you see instead?

Files in .AppleDouble directory should be skipped, possibly all .* directories?

What version of the Munki tools/InstallOSpkg tools are you using? On what 
version of OS X?

MWA git clone as of 3-15-2013

Please provide any additional information below.

I modified the skipdirs variable on manifests/models.py:140 to include 
'.AppleDouble' and that has resolved the issue for now.

Original issue reported on code.google.com by danielha...@gmail.com on 15 Mar 2013 at 6:23

GoogleCodeExporter commented 8 years ago
Daniel,

Is this still an issue? I can't reproduce it using the version I just pushed 
today, but I didn't make any modifications to the code to address this issue. 
Here's what I've got in my manifests directory:

 ls -a /var/www/manifests/
.  ..  .AppleDouble  ._.DS_Store  .DS_Store  site_default

But the only item in my manifests list in MWA is "site_default".

Perhaps this was fixed by someone else and we just need to close the ticket, 
but I wanted to check with you first to verify that assumption.

Original comment by joe.woll...@gmail.com on 24 Mar 2013 at 1:18

GoogleCodeExporter commented 8 years ago
I won't be able test right away, I can probably get to it tuesday.  Just to be 
sure, is .AppleDouble a file or directory in your case?  I know there is a 
check to ignore any filenames that begin with ".", but (in the code version I 
have) the skipdirs only skips .git and.. uhh, shoot something else.  There is 
no general "skip any directory that begins with ."

I'll do a pull on Monday or Tuesday and report back with some ls -al output as 
well.

Original comment by danielha...@gmail.com on 24 Mar 2013 at 3:41

GoogleCodeExporter commented 8 years ago
It was a directory, but an empty one that I made to test the issue. Once I 
threw an empty file in that directory, it appeared in the manifest list. (doh!)

I applied your suggested change and it did indeed resolve the issue. Since it 
was a very minor change I went ahead and pushed it to the production repo: 
https://code.google.com/p/munki/source/detail?r=a2b1f99684ad4efb02bcfbf8fdeb28dd
1a60b285&repo=munkiwebadmin

We really need to get you comfy with git so you can start getting some 
'official' credit!

Original comment by joe.woll...@gmail.com on 24 Mar 2013 at 6:00

GoogleCodeExporter commented 8 years ago
I'm going to go ahead and close this, but if for some reason it doesn't work 
for you I'll reopen it.

Original comment by joe.woll...@gmail.com on 24 Mar 2013 at 6:02