search

gaston-alma / munki

Automatically exported from code.google.com/p/munki
Other
0 stars 0 forks source link

CSS Issue #326

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In the latest version of Munki 2, there's an issue with the CSS issue that only 
allows two items per row.  The problem can be found in base.css at line 672.

CURRENT CSS:

div.lockup-container[data-columns-current="3"] div.lockup:nth-of-type(3n+2) {
    width: 33.5%
}

FIX:

div.lockup-container[data-columns-current="3"] div.lockup:nth-of-type(3n+2) {
    width: 33.3333%
}

Original issue reported on code.google.com by mh...@reallifechurch.org on 5 Jun 2014 at 7:56

GoogleCodeExporter commented 8 years ago 
I have not seen this issue except under a certain unreleased OS. Where/how are 
you seeing it?

(BTW, when you say "latest version of Munki 2, do you mean Managed Software 
Center 4.0.2049  ?  Or some other version of the Managed Software Center 
application?

Original comment by gregnea...@mac.com on 5 Jun 2014 at 9:01

GoogleCodeExporter commented 8 years ago 
Testing on the unreleased OS, setting the width to 33.4% also fixes the issue. 
33.3333% on 10.9 leaves a gap at the end of the row. 33.4% does as well, but 
the gap is smaller. Do you concur that 33.4 is a better compromise?

Original comment by gregnea...@mac.com on 5 Jun 2014 at 11:25

GoogleCodeExporter commented 8 years ago 
 And for what it's worth, the 33.5% value has been there all the time with every release of MSC...

Original comment by gregnea...@mac.com on 5 Jun 2014 at 11:26

GoogleCodeExporter commented 8 years ago 
No responses from the original issue reporter. I've decided to commit a change 
setting the width of the third item to 33.4%.

https://code.google.com/p/munki/source/detail?r=ada656f717117068d4e9b64fd22988c5
62d0df5a&name=Munki2

Original comment by gregnea...@mac.com on 6 Jun 2014 at 8:39