search

gastsail / CocktailApp

Cocktails Android App with Clean Architecture, MVVM , Retrofit, Coroutines, Navigation Components , Room, Dagger Hilt, Cache Strategy and Coroutines Flow
MIT License
446 stars 77 forks source link

Added ability to delete and add to favorites from a CocktailsDetailFragment #2

Closed GeorgCantor closed 4 years ago

GeorgCantor commented 4 years ago

Now the icon changes depending on whether the cocktail is added to favorites or not. Added extension function for showing toast.

GeorgCantor commented 4 years ago

I tested everything and everything works fine

GeorgCantor commented 4 years ago

run and check

gastsail commented 4 years ago

There is no need of being rude, I have understood your PR, I'm just asking for some changes in the code, not treating you bad or anything, this will be closed since you are not behaving like a professional.

I know that it compiles and there is no problems, but there is no need of beign rude when I was asking about the code

gastsail commented 4 years ago

there has been a real improvement in functionality. now you can just add a photo to your favorites and that's it. and I made the user see the changes immediately and can click again to delete from the favorites. but you can only delete through the list of favorites. and i add toast function. with this attitude, I will no longer make pullrequests and waste time. people like you discourage contributing

No, I have not discouraged you from contributing, as I said, I loved your pull request and introduces a really nice feature, I was about to merge it and I reviewed some aspects of the code, you have been extremely rude with me for no reason when what I was trying to do is to review the code with you and just talk about the feature, in any point I was being rude with you, the fact that you acted as an unprofessional is the reason why I refused this pull request, if you have a code review meeting someday you will not treat your teammates like that, you will just talk out the best solution and agree with a solution that is the best for the project, I was just asking nicely about the changes and reviewing your code.

I was really happy to see someone contributing to the repo when I woke up, after reviewing your contribution and after your acting like that made me change my opinion on this pull request.

Maybe next time you can merge your contributions if you act professionally.

GeorgCantor commented 4 years ago

I'm sorry, but it seemed to me that you do not want to accept my request. that's why I reacted like that. pardon me

gastsail commented 4 years ago

I'm sorry, but it seemed to me that you do not want to accept my request. that's why I reacted like that. pardon me

In any way I was not happy with your contribution, I was really happy to see it, I was just asking about how we can do it better to merge it that's why I reviewed it, there is no problem have a good day.