gate-sso / gate

Gate is MFA Enabled SSO Platform that supports SAML, OAuth, Linux shell login and CAS
https://gate-sso.github.io
MIT License
203 stars 52 forks source link

Provide filter for group lists #82

Closed ajeygore closed 6 years ago

ajeygore commented 6 years ago

All group list should provide filter for Only active users and not inactive users, also, prune all inactive members from all the groups.

giosakti commented 6 years ago

I'll work on this

ajeygore commented 6 years ago

Thanks :-)

On 2 Mar 2018, at 6:09 PM, Giovanni Sakti notifications@github.com wrote:

I'll work on this

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gate-sso/gate/issues/82#issuecomment-369879835, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKK_lX197EIhjj99nd78sd87q0onF8Eks5taRpQgaJpZM4SZgxT.

giosakti commented 6 years ago

for pruning, do you mean a button for admin that query and remove all inactive members on all groups, or should it be a periodic worker?

ajeygore commented 6 years ago

There should be button for now, later - when we deactivate a user, he should be removed from all groups if he is deactivated for 15 days.

So that accidental deactivation does not matter.

Ajey

On 4 Mar 2018, at 11:51 PM, Giovanni Sakti notifications@github.com wrote:

[] don't show active users on users autocomplete [] prune all inactive members from all the groups (?) for pruning, do you mean a button for admin that query and remove all inactive members on all groups, or should it be a periodic worker?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gate-sso/gate/issues/82#issuecomment-370239491, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKK_lHrcSfFfu6HvjWfYTsTzgv-Njk_ks5tbA2NgaJpZM4SZgxT.

giosakti commented 6 years ago

ok, I'll create that functionality & button that remove all inactive members from all groups.

As for the second scenario when we deactivate a user, he should be removed from all groups if he is deactivated for 15 days..

I will create a rake task and create a job using whenever to call that rake task every midnight. Thus in every gate deployment we should run whenever --update-crontab so that the job is added to the server's cronjobs.

ajeygore commented 6 years ago

@giosakti is this done?

giosakti commented 6 years ago

In the end I took this approach as per your suggestion:

later - when we deactivate a user, he should be removed from all groups if he is deactivated for 15 days.

please see this PR for details: https://github.com/gate-sso/gate/pull/93 the PR already merged, but we haven't turn on the cron jobs.

We have to run whenever --update-crontab on one of the box for it to be active.

ajeygore commented 6 years ago

I think we should provide Include inactive user as a checkbox on UI to close it.

giosakti commented 6 years ago

sure, will add that

ajeygore commented 6 years ago

Can we close this issue?

giosakti commented 6 years ago

@ajeygore Please check #121 to solve Include inactive user as a checkbox on UI if that is merged, we can close this

ajeygore commented 6 years ago

Done with merge, will wait for build and then we should deploy today or tomorrow.