gatecat / prjoxide

Documenting Lattice's 28nm FPGA parts
ISC License
143 stars 15 forks source link

Fix DCCs tilegrouping #27

Closed mtdudek closed 2 years ago

mtdudek commented 2 years ago

Fix match in bels.rs Change createtilegroups to work with DCCs. They are located in *MID tiles, so R{}C{}{} was incorrect for them. This lead to from_fasm not correctly detecting tilegroup for DCCs.

Signed-off-by: Maciej Dudek mdudek@antmicro.com

mtdudek commented 2 years ago

@gatecat I found issue with my previous PR, here is updated version. This one should work.

gatecat commented 2 years ago

Sorry, this might take a day or two to review as it needs some thought to make sure it's the right approach.

mtdudek commented 2 years ago

After some more testing. It turned out that I only needed to fix bels.rs in prjoxide. I also had to modify fasm.cc in nextpnr so here is accompanying PR to nextpnr https://github.com/YosysHQ/nextpnr/pull/992.

gatecat commented 2 years ago

That looks much better, thanks!