mjguzdial
commented
9 years ago Thanks for all the fixes! I'm going to save the keyboard and mouse events for JES 5.1. This release will be bug fixes only.
- Mark
From: sportsracer48 [notifications@github.com] Sent: Thursday, April 09, 2015 1:07 PM To: gatech-csl/jes Subject: [jes] Fixed purple text bug, raw_input bug, and added keyboard mouse functionality (#85)
Ideally I would have submitted this pull request before adding any features, and it would just be bug fixes, but oh well. Here we are.
First, the bug fixes. If you stop running a program while waiting for raw_input, then the next time you run raw input it immediately throws an error. I fixed this by cancelling the prompt before halting the execution thread. This cannot be the right way to do it, but I'm not sure there is a better way.
I fixed the purple text bug by letting the main thread join the thread that initializes the name space. This removes what was before a race condition.
I also added a bunch of keyboard and mouse input features. As a student learning python with JES, I often wanted to be able to click on displayed pictures, or control them by pressing keys, not typing into the console. With these functions, those both become possible. They have direct queries (isKeyPressed, isLeftMousePressed) and a simplified event queue (hasKeyEvent, getKeyEvent).
It is the unfortunate truth that most people who want to learn to program want to make games. This allows them to do so, but it has other applications, like drawing or image manipulation user interfaces.
Last year I distributed a modified version of JES around my school, which allowed students to use keyboard/mouse input. Everyone who gained the ability immediately jumped on it, and began making games.
If games are what they want to make, why not let them.
I also added a buildAndRun.bat, for convenience.
You can view, comment on, or merge this pull request online at:
https://github.com/gatech-csl/jes/pull/85
Commit Summary
- fixed bug where stopping while waiting for raw_input would cause raw_input to crash in future executions. Added and documented functions for user KBM input
- Merge pull request #1 from sportsracer48/sportsracer48
- revert bug fix, ironically
- Merge branch 'master' of https://github.com/sportsracer48/jes
- Merge pull request #2 from sportsracer48/sportsracer48
- Merge branch 'master' of https://github.com/sportsracer48/jes
- removed profanity
- Merge pull request #3 from gatech-csl/master
- and yet the raw_input bug survived, so we return to my hack
- Fixed a bug where the interpreter would not wait for its namespace to be set up.
- changed 'to' to 'too' in help html
File Changes
- A .classpathhttps://github.com/gatech-csl/jes/pull/85/files#diff-0 (16)
- M .gitignorehttps://github.com/gatech-csl/jes/pull/85/files#diff-1 (1)
- A .projecthttps://github.com/gatech-csl/jes/pull/85/files#diff-2 (17)
- A buildAndRun.bathttps://github.com/gatech-csl/jes/pull/85/files#diff-3 (3)
- M jes.bathttps://github.com/gatech-csl/jes/pull/85/files#diff-4 (1)
- M jes/help/JESAPIHelp.htmlhttps://github.com/gatech-csl/jes/pull/85/files#diff-5 (134)
- M jes/java/JESstartup.javahttps://github.com/gatech-csl/jes/pull/85/files#diff-6 (1)
- M jes/java/PictureFrame.javahttps://github.com/gatech-csl/jes/pull/85/files#diff-7 (15)
- M jes/java/SimplePicture.javahttps://github.com/gatech-csl/jes/pull/85/files#diff-8 (3)
- A jes/java/input/KeyInput.javahttps://github.com/gatech-csl/jes/pull/85/files#diff-9 (70)
- A jes/java/input/MouseInput.javahttps://github.com/gatech-csl/jes/pull/85/files#diff-10 (104)
- M jes/python/jes/core/interpreter/init.pyhttps://github.com/gatech-csl/jes/pull/85/files#diff-11 (20)
- M jes/python/jes/gui/commandwindow/prompt.pyhttps://github.com/gatech-csl/jes/pull/85/files#diff-12 (5)
- M jes/python/jes/gui/helpinfo.pyhttps://github.com/gatech-csl/jes/pull/85/files#diff-13 (4)
- M jes/python/jes/program.pyhttps://github.com/gatech-csl/jes/pull/85/files#diff-14 (5)
- M jes/python/media.pyhttps://github.com/gatech-csl/jes/pull/85/files#diff-15 (43)
- M working-on-jes/sample-plugin/plugin.propertieshttps://github.com/gatech-csl/jes/pull/85/files#diff-16 (2)
- M working-on-jes/sample-plugin/python/greetings.pyhttps://github.com/gatech-csl/jes/pull/85/files#diff-17 (2)
Patch Links:
— Reply to this email directly or view it on GitHubhttps://github.com/gatech-csl/jes/pull/85.
alinacampan
Ideally I would have submitted this pull request before adding any features, and it would just be bug fixes, but oh well. Here we are.
First, the bug fixes. If you stop running a program while waiting for raw_input, then the next time you run raw input it immediately throws an error. I fixed this by cancelling the prompt before halting the execution thread. This cannot be the right way to do it, but I'm not sure there is a better way.
I fixed the purple text bug by letting the main thread join the thread that initializes the name space. This removes what was before a race condition.
I also added a bunch of keyboard and mouse input features. As a student learning python with JES, I often wanted to be able to click on displayed pictures, or control them by pressing keys, not typing into the console. With these functions, those both become possible. They have direct queries (isKeyPressed, isLeftMousePressed) and a simplified event queue (hasKeyEvent, getKeyEvent).
It is the unfortunate truth that most people who want to learn to program want to make games. This allows them to do so, but it has other applications, like drawing or image manipulation user interfaces.
Last year I distributed a modified version of JES around my school, which allowed students to use keyboard/mouse input. Everyone who gained the ability immediately jumped on it, and began making games.
If games are what they want to make, why not let them.
I also added a buildAndRun.bat, for convenience.