Bug fix for issue #6 - (Py2 to Py3 Hmac) opened by @araa47

gateio / WebSocket-API

gateio WebSocket-API

56 stars 32 forks source link

Bug fix for issue #6 - (Py2 to Py3 Hmac) opened by @araa47 #9

Closed 0GCRYPT0 closed 4 years ago

0GCRYPT0 commented 4 years ago

My bug fix addresses the issue brought up by @araa47 which causes what I believe is a critical break in functionality for python3 developers. The bug essentially breaks Auth for python3 developers by breaking the get_sign function needed to generate a signature required to authenticate. Python2 I believe is EOL since January 1st, 2020, so I believe this fix adds tremendous value to this project.

0GCRYPT0 commented 4 years ago

Can we have someone review this? @gateio @5izena @revilwang

revilwang commented 4 years ago

Thanks for the pull request. I'll have a look at it later

revilwang commented 4 years ago

I don't have the right to merge a pull request. But your fix works both in Python 2 and Python 3

0GCRYPT0 commented 4 years ago

Thanks for testing the fix out. I appreciate you. Hopefully someone with write access is still maintaining this repo.

revilwang commented 4 years ago

@0GCRYPT0 Now the request is merged