gateship-one / odyssey

Odyssey music player
GNU General Public License v3.0
235 stars 39 forks source link

[FR] id3v2 support #165

Open mkgvt opened 6 years ago

mkgvt commented 6 years ago

id3v2 tags which show up as Chinese characters. I don't want to go back to id3v1 tags because they are not long enough to contain performer and title information for many of my albums and tracks.

mkgvt commented 6 years ago

Did a little browsing of the code and this appears to be an Android problem. MediaMetadataRetriever doesn't seem to handle id3v2 tags. Some bug reports I found suggest that other applications work around the problem by explicitly re-reading the file to pull out the tags. Until Android fixes it, that may be what we have to do.

djselbeck commented 6 years ago

Android does in fact read id3v2 but we are aware of certain letter combinations that seem to trip up the Android tag reading implementation or the framework behind it. This will result in invalid media db entries.

The only reason to work around this would be to read tags on our own. Either by implementing a tag reader or using an available opensource library.

mkgvt commented 6 years ago

What combination causes the problem? (So I can avoid it.)

djselbeck commented 6 years ago

We are not really sure on that part. We observed it with letters combined with `,´,^ and Cyrillic letters for example.

gnome17 commented 6 years ago

Here are two examples which maybe illustrates why we are not sure what is happening there:

In the first case I had an album from which two songs were separated in another album for some reason. But both had the same name and cover. One of the songs had an issue with the artist name and showed some "broken" letters. But after I changed the songname which contained " ` ", " ´ " and "^" and also the filename (just to be safe ;-) ) the issue was gone.

Another example was an album that was completely messed up after i removed the " ` ", " ´ " and "^" it worked.

In both cases I removed the complete album fixed the mentioned things and readded them again.

So it seems android sometimes couldn't handle those letters for some reason.

Maybe these two examples could guide you in the correct direction to solve your issue.

PrSunflower commented 4 years ago

Hello, I had similar issues recently with some song names and artist names.

Example 1

A group named Økuna shows normally on my computer but appears as "Řkuna" on Odyssey.

Example 2

A typewriter apostrophe causes 3 characters to appear in a song title. Quite funny I have to say!

Please see screenshots below:

Inside Odyssey

Screenshot_20200201-113231

In the notification panel

Screenshot_20200201-113212


If I understand what you said in issue #188 then there is nothing I can do because all depends on the Android Media Database, right?

Of course, thank you for all the hard work, Odyssey is a superb-looking music player, you can be proud of your work.

gnome17 commented 4 years ago

Hi, yes you are right. Unfortunately there is nothing we do about it at the moment.

A simple workaround would be the one I mentioned in my last comment for this issue.

And thank you for your kind words :)

salewski commented 2 years ago

... One of the songs had an issue with the artist name and showed some "broken" letters. But after I changed the songname which contained " ` ", " ´ " and "^" and also the filename (just to be safe ;-) ) the issue was gone.

Another example was an album that was completely messed up after i removed the " ` ", " ´ " and "^" it worked.

In both cases I removed the complete album fixed the mentioned things and readded them again.

So it seems android sometimes couldn't handle those letters for some reason. ...

Thank you for that hint, @gnome17. That helped me fix an issue with album art not displaying correctly on a particular album whose name was in the form:

    YYYY Foo (Bar Baz)

I changed it to be in the form:

    YYYY Foo Bar Baz

After removing the ( and ) characters from the album name, and then updating the media database at the relevant location from within Odyssey, the album art for that item now shows up in the app.