search

gateship-one / odyssey

Odyssey music player
GNU General Public License v3.0
232 stars 39 forks source link

Incorrect sorting of track numbers #192

Open alanorth opened 4 years ago

alanorth commented 4 years ago

Bug Report

Setup Description

Version of Odyssey

Odyssey 1.1.18.

Android Version

Android 10.

Device Manufacturer and model

Nokia 7.1

Bug Description

Description

Media files with track numbers larger than 10 are sorted incorrectly:

Reproducible

Expected Behaviour

Media files should be sorted numerically according to their track numbers:

  1. Track 1
  2. Track 20
  3. Track 107

Actual Behaviour

Media files with track numbers larger than 10 are sorted incorrectly:

  1. Track 1
  2. Track 107
  3. Track 20

signal-attachment-2020-01-19-101233

djselbeck commented 4 years ago

Are you sure that your files are tagged correctly?

Odyssey sorts first the disc tag and then the track number. If your tracks have diverging disc numbers this would explain your broken sorting.

alanorth commented 4 years ago

Attached is another example with screenshot and ID3 tag dump for two tracks. At first I thought it was only where track numbers were greater than 99, but now I realize that all my albums are sorted incorrectly!

ID3 tags

$ eyeD3 01\ -\ A\ Bid\ Farewell.mp3
...
track: 1/12
disc: 1/1
$ eyeD3 10\ -\ And\ Embers\ Rise.mp3
...
track: 10/12
disc: 1/1

Screenshot

odyssey-incorrect-sorting

djselbeck commented 4 years ago

Is this ID3v1 or ID3v2? There needs to be some problem with Android not reading the tags correctly. Please upload a complete tag dump

alanorth commented 4 years ago

The two files in this last case are both ID3 v2.3 (as far as I know all my music is, as I tag them with MusicBrainz Picard and beets). Attaching dump from eyeD3 for both files.

Thanks!

0rganite commented 4 years ago

I have the same problem on Android 10 with ID3 v2.3. I fix it by removing the division in the track field: 10/12 --> 10

gnome17 commented 3 years ago

Since I updated to Android 10 I had this issue as well and others.

We weren't able to come up with a good solution for this problem. I only noticed that this problem will not appear in an Emulator Running Android 11.

Our workaround solution will be another sort option for tracks by filename.

This will require that your tracks are named properly. We know that is not ideal but the best we can do right now. It will be an option in the settings and we will ship this change with the new release of odyssey which should take place this month.