search

gateship-one / odyssey

Odyssey music player
GNU General Public License v3.0
232 stars 39 forks source link

Add singular and plural #223

Closed Valdnet closed 2 years ago

Valdnet commented 2 years ago

For the text string below, add both singular and plural, as the word "seconds" should vary depending on the number of seconds.

https://github.com/gateship-one/odyssey/blob/4576abc5ddfc9e79056e9ea0223b37af004ae672/app/src/main/res/values/strings.xml#L339

Example:

<item quantity="one">Step size: %d second</item>
<item quantity="few">Step size: %d seconds</item>
<item quantity="many">Step size: %d seconds</item>
<item quantity="other">Step size: %d seconds</item>

I understand that this requires a code change, but this change needs to be done because this text string is a sentence.

gnome17 commented 2 years ago

I think we have currently more urgent topics to work on but I keep it in the back of my head and will think about a fix which ideally won't require any or few adjustments to the already existing translations.

gnome17 commented 2 years ago

Fixed. Feel free to fixup the polish translation because I added only placeholders for all languages I cannot translate by myself.

Valdnet commented 2 years ago

Translated in #233 😉.