search

gateship-one / odyssey

Odyssey music player
GNU General Public License v3.0
235 stars 39 forks source link

Android automatic refactor - Recycle #42

Closed luiscruz closed 7 years ago

luiscruz commented 7 years ago

Hi,

I am developing a tool to automatically refactor Android applications with the goal of improving energy efficiency. This pull request has the changes generated while applying the rule "Recycle".

Some resources (e.g., Cursor instances) should be closed when they are no longer necessary.

I have made a previous validation of the changes and they seem correct. Please consider them and let me know if you agree with them.

Best, Luis

gnome17 commented 7 years ago

Hi,

thanks for your participation. We checked your request and it seemed correct but the code formatting is broken. We cannot merge this request until you fix that. Despite of that we are not quite sure how an optimization of unit tests will improve the performance of an android app or even improve the energy efficiency.

luiscruz commented 7 years ago

Hi @gnome17 In fact such optimization in tests will not have any effect in the app. Thanks for looking into this!

gnome17 commented 7 years ago

Hi,

if you don't mind i will close this pull request. But feel free to participate again if you found any further optimizations.