search

gateship-one / odyssey

Odyssey music player
GNU General Public License v3.0
232 stars 39 forks source link

[FR] add a delete current track option #71

Closed Shuunen closed 7 years ago

Shuunen commented 7 years ago

Hi :) first thanks for the app !

It would be great to have a "Delete current song" option in the menu when on playing screen, I use this feature on other media player to delete songs I don't like and free space

gnome17 commented 7 years ago

Hi, we are currently not planning to add this kind of feature. We think this kind of feature should be limited to file explorer apps.

ildar commented 7 years ago

🙂 Since Odyssey has the file exploring ability then it's probably a good idea to add "remove" option to it in Files view. That'd add the unique scenario for users: Browse, Listen, Evaluate, Remove

Shuunen commented 7 years ago

We think this kind of feature should be limited to file explorer apps.

I don't see why. For example if you take music as a media, photo is a media too,

Listen to music is like viewing photos, once you've seen a photo you don't like, if you want to delete it you switch to a file explorer and reach /the/good/DCIM/folder/20170613-7654767.jpg to delete the file manually ?

djselbeck commented 7 years ago

Hello,

we would like to keep Odyssey non destructive. Because otherwise we would have to be more careful and make sure that users don't accidentally remove their files.

In contrast to photos that are mostly snapshots on a phone music is not. That's why I think the comparison to photos is not quite fair. Also Odyssey is not really a filebrowser. For example we also do not have a rename or make directory functionality.

Greetings Hendrik

Am 13. Juni 2017 16:09:01 MESZ schrieb Romain Racamier notifications@github.com:

We think this kind of feature should be limited to file explorer apps.

I don't see why. For example if you take music as a media, photo is a media too,

Listen to his music is like viewing his photos, once you've seen a photo you don't like, if you want to delete it you switch to a file explorer and reach /the/good/DCIM/folder/20170613-7654767.jpg to delete it ?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/gateship-one/odyssey/issues/71#issuecomment-308128056

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Shuunen commented 7 years ago

In contrast to photos that are mostly snapshots on a phone music is not

What ?

Also Odyssey is not really a filebrowser. For example we also do not have a rename or make directory functionality.

No one mentioned "rename or make directory"...

No one suggest Odyssey to become a filebrowser, except if you consider that all app that can delete a file is a filebrowser.

https://www.techwibe.com/wp-content/uploads/2015/02/Long-press-on-a-music-file-to-play-continuously.jpg

http://www.wikihow.com/images/e/eb/Delete-Music-from-Google-Play-Step-4.jpg

Screenshots from VLC & Google Play Music - both android apps and well known "filebrowsers"

djselbeck commented 7 years ago

Hello,

maybe you have missed the history of this commit, but ildar in a friendly way suggested that "Since Odyssey has the file exploring ability then it's probably a good idea to add "remove" option to it " to which I am referring as a file manager it was meant as a joke.

The differentiation between music and photos on a phone is that removing photos is a common action like removing photos with bad exposure, etc but music is usually not recorded on the phone and downloaded or transferred in some way and should not be as easily removed. Maybe this is a personal opinion but I would be angry if I remove a wrong album or even a track in my music library.

And to finish this we would like to stay non destructive.

ildar commented 7 years ago

Then it's logical to have an option to open a folder in a true file manager.

greenpeteuk commented 5 years ago

I see that the dev is not at all happy about adding the delete function, which is a shame, as that is the only thing stopping me from adopting Odyssey as my default music player. So I would just like to add my name to the list of users that would like this functionality.

I listen to a lot of podcasts and when I have listened to them, I like to delete them. Switching to another app to do this is a pain.

I understand why it would be painful to delete the wrong file by accident, but this thinking condemns people that take responsibility for their own actions to using an app that is lacking, just because some may not have the brains to be careful and/or to backup or the responsibility to use a tool carefully or just accept they screwed up.

It's a shame that this is the case. Very nice app otherwise, I particularly like the bookmark feature, thanks! :-)