Shuffle

[RobertCMonahan]

swapped shuffle and random buttons

the random button (in the bottom right of the nowplaying view) now has the shuffle function and the random button has been moved into the drop down menu (where the shuffle previously was). This is for a better and more predictable user experience. The shuffle button will create a list to play and shuffle it just as it worked previously, when shuffle is turned off the list is reset to the original order while the current playing song continues.

[djselbeck]

Why would you create such a PR without contacting us first?

It is very unlikely that we will merge this for multiple reasons.

1. I like the behaviour as it is at the moment
2. I don't like the idea of a copy of the same list in memory
3. The unshuffled list is not saved on application exit.

[RobertCMonahan]

I wasn't aware that that would be a problem. What would be your preferred way of making contributions?

OK thanks for the feedback. I could keep the shuffle button in the drop down. I think I could reset the list without saving a copy if memory, and also save the state on exit. Might somthing like that be more appropriate?

[djselbeck]

To open a pull request is not the problem here. The problem is with PRs that change the existing behaviour, UI or anything else substantial without asking first ;).