search

gateway-experiments / remote_kernel_provider

Base support for remote kernel providers
Other
3 stars 3 forks source link

Remove container-based launchers #17

Closed kevin-bates closed 5 years ago

kevin-bates commented 5 years ago

The container-based launchers for kubernetes and docker will be hosted by their respective kernel providers since they contain scripts relative to those providers. The actualy kernel launchers will remain here since they are common to all providers (at some point).

With this change, the spec utilities were updated to allow for only resource files (icons, etc.) to be copied since the container-based launchers will position their pod/container launchers appropriately.

This will trigger a 0.2.0 release of Remote Kernel Provider on which the container-based providers will minimally depend.

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   49.33%   49.42%   +0.08%     
==========================================
  Files          11       11              
  Lines        1129     1131       +2     
==========================================
+ Hits          557      559       +2     
  Misses        572      572
Impacted Files Coverage Δ
remote_kernel_provider/spec_utils.py 100% <100%> (ø) :arrow_up:
remote_kernel_provider/tests/test_spec_utils.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2a9765...2fc96ef. Read the comment docs.