search

gateway-experiments / remote_kernel_provider

Base support for remote kernel providers
Other
3 stars 3 forks source link

Add ability for providers to override find_kernels() #18

Closed kevin-bates closed 5 years ago

kevin-bates commented 5 years ago

It would be useful to allow providers to perform pre/post ops for find_kernels(). For example, the KubernetesKernelProvider will (quietly, via logging) enforce that it be run from within a Kubernetes cluster and will not make k8s kernels available until then. These changes enable that behavior.

codecov-io commented 5 years ago

Codecov Report

Merging #18 into master will increase coverage by 0.57%. The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #18      +/-   ##
========================================
+ Coverage   49.42%    50%   +0.57%     
========================================
  Files          11     11              
  Lines        1131   1148      +17     
========================================
+ Hits          559    574      +15     
- Misses        572    574       +2
Impacted Files Coverage Δ
remote_kernel_provider/provider.py 80% <100%> (+0.83%) :arrow_up:
remote_kernel_provider/tests/test_provider.py 96.15% <87.5%> (-1.6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fad7ef6...a2d4efc. Read the comment docs.