gatewayapps / kamino

Github issue cloning tool
GNU General Public License v3.0
85 stars 25 forks source link

[BUG] Extension's styles break layout for "Checks..." section on pull requests #202

Closed patrickhlauke closed 4 months ago

patrickhlauke commented 4 months ago

Describe the bug

When the extension is installed/enabled, items in the "Checks..." section on pull requests break out of their container box.

Screenshot showing a failing 'Check', with its item overflowing the overall 'Checks' container left and right

Disabling the extension and reloading, the problem goes away, so it's definitely related to whatever styles this extension injects.

Screenshot of the same section, now with the correct layout

PR used to test this: https://github.com/w3c/wcag/pull/3909 (though it'll likely be merged and closed by the time this gets looked at)

To Reproduce Steps to reproduce the behavior:

  1. Go to a pull request with checks with the extension enabled - observe the problem with layout
  2. Disable the extension
  3. Reload the page - notice the layout problem is gone

Expected behavior

The styles should not break the layout of the "Checks..." section.

Screenshots See above

Desktop (please complete the following information):

johnmurphy01 commented 4 months ago

@all-contributors please add @patrickhlauke for bugs

allcontributors[bot] commented 4 months ago

@johnmurphy01

I've put up a pull request to add @patrickhlauke! :tada:

johnmurphy01 commented 4 months ago

@patrickhlauke thanks! I verified you bug report. It looks like I'm indeed using a open class and setting the display to inline. GitHub also uses a open class but they aren't putting any CSS styling into it. So I should be able to scope my CSS so that it doesn't affect other parts of the page.

patrickhlauke commented 4 months ago

lovely, thank you

johnmurphy01 commented 4 months ago

@patrickhlauke I've submitted a new version of Kamino (4.0.1). Once it's approved by the web store, it should be available.