search

gather-community / gather

The App for Community
https://info.gather.coop
MIT License
30 stars 6 forks source link

Update en.yml , reminder subject #1002

Closed enginegrid closed 10 months ago

enginegrid commented 1 year ago

Updating to meal reminder email, line 444 updating subject line to move "date/time" to the left, to improve visibility in mobile email application.

enginegrid commented 1 year ago

Before: Meal Reminder: Peanut Sesame Noodles on Wed Sep 13 6:15pm at GO CH

After (expected): Meal Reminder: Wed Sep 13 6:15pm - Peanut Sesame Noodles at GO CH

On Sun, Oct 1, 2023 at 8:40 AM Tom Smyth @.***> wrote:

@.**** commented on this pull request.

Could you please paste some example subjects before and after the change? Also it seems the tests didn’t run, perhaps because it’s your own clone. I will look into this later

— Reply to this email directly, view it on GitHub https://github.com/gather-community/gather/pull/1002#pullrequestreview-1651897230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUWH6ZFZWQIKEH7PPL24NHTX5FQDDANCNFSM6AAAAAA5NQC2YY . You are receiving this because you authored the thread.Message ID: @.***>

smoyte commented 1 year ago

@enginegrid the change looks good, but I want to make sure it doesn't break any tests.

For some reason the tests didn't run on this PR. Perhaps b/c it came from your clone?

Are you able to clone the to push your branch to the main repo?

git checkout your_branch
git remote add main git@github.com:gather-community/gather.git
git push main
enginegrid commented 10 months ago

Added a branch "alex_branch" and pushed it up