search

gathering / gondul

Network management/monitoring system specialized for temporary events
http://tech.gathering.org
GNU General Public License v2.0
42 stars 10 forks source link

#159 Fixed templating install, included updated varnish config, updated installing.rst and clean-up on servicefiles #201

Closed slinderud closed 5 years ago

slinderud commented 5 years ago

I also renamed config.pm.dist because i got bored of fixing it every time i install it.

This fixed #159 Install dependencies for the template engine (flask and netaddr) Updated varnish vcl to include /template api And updated install doc to explain how to do basic authentication.

Edit: We also turned this into a servicefile-cleanup since @lasseh wanted to. Then we have someone to blame!

sklirg commented 5 years ago

I think the point of naming the config file something other than config.pm is so that it won't be dirty in the git tree when you edit configuration variables (which will prevent you from being able to merge origin into your local clone).

With that said, I much more prefer having some default values so that you don't have to copy the file when you want to use the system; the system should have some sane default values which makes the system possible to run without having to set the configs manually.

Just my two cents. 😁 I'd say revert the config rename to avoid having that as blocker for the rest of this feature :)

KristianLyng commented 5 years ago

I think the point of naming the config file something other than config.pm is so that it won't be dirty in the git tree when you edit configuration variables (which will prevent you from being able to merge origin into your local clone).

With that said, I much more prefer having some default values so that you don't have to copy the file when you want to use the system; the system should have some sane default values which makes the system possible to run without having to set the configs manually.

We talked about this - and that is indeed the reason. But there are a hundred ways to solve this. One of them is to have config.pm do a conditional include of config.local.pm or similar. A better yet is to actually use proper config-file locations and have config.pm in the repo be sensible defaults that you would never modify on an installed system. Either way, I'm fine with renaming it for now and fixing the include-thing later.