gathering / wannabe

Event-system for TG - wannabe.gathering.org
GNU General Public License v3.0
12 stars 7 forks source link

Improve passord handling #24

Closed niccofyren closed 4 years ago

niccofyren commented 4 years ago

This PR introduces a "couple" of tweaks to how passwords and login are handled:

Checklist for getting in prod:

Relates to: https://github.com/gathering/wannabe/issues/9 Relates to: https://github.com/gathering/wannabe/issues/8 (Maybe 🤷‍♂)

Brekkjern commented 4 years ago

You are correct that the /api/login.php endpoint is the legacy API and should be nuked from orbit.

Brekkjern commented 4 years ago

I had a look through the code and it looks fine, but I had no opportunity to test it out. Anyone else able to give this a shot?

KristianLyng commented 4 years ago

It looks good to me. And for the record, the old /api/login.php is not in use - it's blocked by apache as well, so no harm in nuking it.

Merging.