search

gathering / wannabe

Event-system for TG - wannabe.gathering.org
GNU General Public License v3.0
12 stars 7 forks source link

Fix error message placement in "create user" workflow #28

Closed mkberntsen closed 4 years ago

mkberntsen commented 4 years ago

If you try to create a user by entering an email which is already associated with a previous user, an error message is displayed - in the wrong place. Error message should show in the dialogue to enter the address, but is shown in the wannabe login page, 'behind' the dialogue.

Reproduce

Step 1:

Click "create user" and enter email address for existing user. Hit 'create' and observe nothing seems to happen. image

Step 2:

Exit the dialogue.

Step 3:

A magical error message has appeared! The link in the error message takes me to... the login page I'm already on? image

niccofyren commented 4 years ago

Think this might already have a fix on its way in this PR: https://github.com/gathering/wannabe/pull/24 this line https://github.com/gathering/wannabe/blob/246c45c2328b39ec513457c2d387f4d0c9d87af2/app/View/Layouts/front-generic.ctp#L47

Did some tweaks to verification logic which included adding a placement for these kinds of messages on the create user / forgot password pages.