search

gathering / wannabe

Event-system for TG - wannabe.gathering.org
GNU General Public License v3.0
12 stars 7 forks source link

Add crew name validation #31

Closed niccofyren closed 3 years ago

niccofyren commented 4 years ago

Adds crew name validation to Crew model:

Adds workaround to /Crew/Edit/xx form to be able to display field validation errors. Form uses separate post endpoint per tab, which has no default CakePHP support for passing validation data back to view. So instead we just convert any errors to flash messages to make sure they are displayed (we still loose previous form data along the way).

Fixes undefined index error when trying to purge cache data for non-existent crew id.

Fixes: https://github.com/gathering/wannabe/issues/15

niccofyren commented 4 years ago

Updated to allow a few more special characters. Had to do some extra decoding before querying crew name lookup, hopefully not a security issue since query method itself should escape for sql-query later. Also added some urlencoding to crewpage wiki lookup (it looks up via generating a "fake" url) to keep thing url safe.

niccofyren commented 3 years ago

Quite a long time since this was created, so was hopefully to self-review it without too many previous assumptions. Added a subtle cache improvement.