search

gathering / wannabe

Event-system for TG - wannabe.gathering.org
GNU General Public License v3.0
12 stars 7 forks source link

Development Environment with Docker Compose? #6

Closed simenandre closed 4 years ago

simenandre commented 4 years ago

Hello 👋

I'd like to suggest that we add a docker-compose.yml file. This way it's easy for anyone to boot the project – and well, quicker.

Can also be used for integration testing. I can probably create a pull request on it.

KristianLyng commented 4 years ago

I was thinking along the same lines. Care to do the honors?

simenandre commented 4 years ago

Yeah – might not be until mid next week tho'. 👍

Atriusftw commented 4 years ago

I recommend using PHP7 in the composefile :)

simenandre commented 4 years ago

PHP7 with latest version then?

Koch commented 4 years ago

I'll start working on this too, asap :)

simenandre commented 4 years ago

@Koch Oh, if you do this, I'll leave it then?

Koch commented 4 years ago

I can do this, yeah!

KristianLyng commented 4 years ago

So I threw together something really basic because I'm impatient. This still doesn't really work, but not because of docker.

The Dockerfile in the repo will set up most things you really need, but since our code-base isn't really compatible with php7.3, we need to make some updates. I've started on these, but it'll take a little while since I need to ensure the old version keeps working until we can switch production.

I'm keeping this issue open because until the dev environment is actually DECENT, there's tons of work to do.

KristianLyng commented 4 years ago

ffs, how can github NOT support files with ".patch" ........ what stupid fucked up shit is this.

Anyway, this is what I did to get the front page to work. Some of this is pretty straight forward and non-controversial (e.g.: Actually defining variables before using them), but I need to verify some of it (e.g.: the ini-lol, and locale obviously). But it should give people an idea of what's needed.

php7.3.patch.txt

Koch commented 4 years ago

Going to be looking at this this weekend when I have a bit more time to use, and will hopefully have a PR coming up that we can work in.

Atriusftw commented 4 years ago

Closing this as we now have a working docker-compose setup from #30 🎉