Implement one of zabra's (Boris S.) performance fixes, make the performance test more lenient

gatoatigrado / vimap

Variations on imap

Other

12 stars 7 forks source link

Implement one of zabra's (Boris S.) performance fixes, make the performance test more lenient #20

Closed gatoatigrado closed 10 years ago

gatoatigrado commented 10 years ago

For the record: zabra's performance fix didn't have that much effect when the CPU was completely idle, but when loaded (hence, I presume, workers finishing at different times?) it moved my back-of-envelope PerformanceTest.test_performance timings from 58% efficiency (standard deviation of 8%) to 73% efficiency (standard deviation of 6%). That's using 8 samples on both, loading with some other performance test tasks. I'm pretty sure it's good.

gatoatigrado commented 10 years ago

I also ran 'tox' 20 times, and made sure nothing flakes with the performance fix. (I guess the flake in #16 didn't show up).

jolynch commented 10 years ago

Shipit