search

gatsbyjs / gatsby-hi

Hindi translation of Gatsbyjs.org
8 stars 28 forks source link

docs/gatsby-cli.md translation #11

Closed NileshPatel17 closed 4 years ago

NileshPatel17 commented 4 years ago

changes done.

arshadkazmi42 commented 4 years ago

@NileshPatel17 Added some comments, you have missed a couple of changes.

NileshPatel17 commented 4 years ago

fixed all changes, and also reviewed entire document again.

arshadkazmi42 commented 4 years ago

@NileshPatel17 Thank you for working on the feedbacks. There is two more feedbacks pending, once those are fixed I will review the rest of the document.

NileshPatel17 commented 4 years ago

new code pushed.

NileshPatel17 commented 4 years ago

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

arshadkazmi42 commented 4 years ago

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url https://github.com/gatsbyjs/gatsby-hi/pull/11/files

NileshPatel17 commented 4 years ago

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url https://github.com/gatsbyjs/gatsby-hi/pull/11/files

so, you switch between conversation and file changed tab while reviewing the issues?

arshadkazmi42 commented 4 years ago

post new code pushed, when i go to review comment section, i do not see new changes in some cases.

feedback section does not shows latest code. you could see the latest changes by clicking on the files tab on top, which will redirect to below url https://github.com/gatsbyjs/gatsby-hi/pull/11/files

so, you switch between conversation and file changed tab while reviewing the issues?

correct

NileshPatel17 commented 4 years ago

are you good to resume the review process or are you waiting from my end. Please let me know.

arshadkazmi42 commented 4 years ago

@NileshPatel17 I will review it later today. Thanks for waiting

NileshPatel17 commented 4 years ago

Great work with fixes. Added review till 115. Let's get these feedback closed then we will contrinue with rest of the file review

except 2-3 items, rest done.

arshadkazmi42 commented 4 years ago

@NileshPatel17 Good work đź‘Ť . Added few comments on couple of feedbacks. Can you work on those? We will resume review post these fixes

NileshPatel17 commented 4 years ago

@NileshPatel17 Good work . Added few comments on couple of feedbacks. Can you work on those? We will resume review post these fixes

Done.

arshadkazmi42 commented 4 years ago

Added comments, let me know if you need anything else. Can you work on the unresolved feedbacks. Thanks

arshadkazmi42 commented 4 years ago

Great. only 1 is pending

NileshPatel17 commented 4 years ago

Looks good to me. let me know if i miss out any thing or any mistake

arshadkazmi42 commented 4 years ago

@NileshPatel17 Great job. Added some more feedbacks. Few were missed. Let's get those closed and get this PR landed

NileshPatel17 commented 4 years ago

overall looks good to me now.

arshadkazmi42 commented 4 years ago

@NileshPatel17 Great work. Just 1 more to fix, and we will get this merged

gatsbot[bot] commented 4 years ago

Holy buckets, @NileshPatel17 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

arshadkazmi42 commented 4 years ago

Holy buckets, @NileshPatel17 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. **We’d like to send you some Gatsby swag.** As a token of our appreciation, you can go to the [Gatsby Swag Store](https://store.gatsbyjs.org) and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock _even more_ free swag with 5 contributions — wink wink nudge nudge.) See [gatsby.dev/swag](https://gatsby.dev/swag) for details.

2. **We just invited you to join the Gatsby organization on GitHub.** This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Thanks and congrats on landing your first PR. You can claim your welcome swag from above URL. 🎉

NileshPatel17 commented 4 years ago

@arshadkazmi42 Thanks!