Open imrishabh18 opened 4 years ago
@imrishabh18 there are two issue in two fixes. can you work on those.
also do not mark comments as resolved. just add the 👍 emoji after fixing. reviewer will review the fix and mark it as resolved
@imrishabh18 those issues are still not fixed. can you have a look at my comments above
i think your resolve merge conflicts commit reverted the fixes.
@arshadkazmi42 Is this fine now ?
@arshadkazmi42 Hey, check this once
@imrishabh18 there is one more open feedback. can you have a look at it
@arshadkazmi42 Hey, It's been a long time since I have resolved the changes. Mind taking a look ?