search

gatsbyjs / gatsby-starter-landing-page

Create custom landing pages using Gatsby and Contentful
https://landingpagestarter.gatsbyjs.io/
57 stars 26 forks source link

add gatsby-provision-contentful and update README #44

Closed aghreed closed 2 years ago

aghreed commented 2 years ago

This PR adds the gatsby-provision-contentful package and replaces the existing setup script with a gatsby-provision script.

It also updates the README to better advertise the gatsby-provision functionality.

gatsby-cloud[bot] commented 2 years ago

Gatsby Cloud Build Report

gatsby-starter-landing-page

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 18s

Performance

Lighthouse report

Metric Score
Performance :green_heart: 97
Accessibility :green_heart: 100
Best Practices :green_heart: 100
SEO :green_heart: 92

:link: View full report

aghreed commented 2 years ago

Generally LGTM.

However, as a long term approach we need a different structure. What I mean by that

  • Installation

    • Gatsby Cloud ...
    • Locally ...
  • Deployment ...

And in Deployment we describe what has been already described in the Installation > Gatsby Cloud section and what in context of the manula content setup described int Installation > Locally could be a source of misunderstanding

I have not a proof solution for that, but maybe we should write two separate sections:

  • Quick deploy to Gatsby Cloud ... with deploy-now&auto-provision description
  • and Development & Deploy ... where we describe the 'manual' way of setting thins up.

but that's an idea for the future.

I like the thought a lot. It did feel a bit odd the way I did this, but ultimately didn't know how to exactly structure it better. Let's see if I can wordsmith a bit more before merging!