Closed tesseralis closed 4 years ago
Hiya!
This issue has gone quiet. Spooky quiet. π»
We get a lot of issues, so we currently close issues after 30 days of inactivity. Itβs been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!
Thanks for being a part of the Gatsby community! πͺπ
it would be good if the error message give a little bit more info about the source of the error
we can guess about the NPMPackage.type.ts
but which field or which file / creator / stacktrace would be nice...
it would be helpful if the error message print also the property/field name
Hi, I would like to take this one. I'll assign it to me π
it would be helpful if the error message print also the property/field name
@muescha after reading the code I realized the error says what the problematic property/field is: NPMPackage.types.ts
, that types.ts
is the field with the problem.
The problem is that the field ts
from Algolia
comes with the values specified in the error: sometimes the string 'included'
others the boolean false
. I haven't found much info about this field on the internet but it looks like the only two possible values are 'included'
or false
, so, we could change that 'included'
to true
unless someone knows about another possible string value different that 'included'
. Or we could do the inverse and change false
to some string like 'notIncluded'
.
Thanks for explanation :)
π€¦ββοΈand I was thinking this NPMPackage.types.ts
was a automagically generated types typescript file
Since we moved the source for the website this isn't a concern for www
anymore. However, the source plugin itself could get this improvement (and another fix). I opened a new issue for it, @jzabala if you want to tackle it let us know in the issue: https://github.com/gatsbyjs/gatsby/issues/26836
Description
Steps to reproduce
Run
gatsby develop
onwww
.Expected result
No warnings.
Actual result
The above warning.
Environment