gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.27k stars 10.31k forks source link

Invalid plugin options "related_applications" gatsby-plugin-manifest #29112

Closed samponeill closed 3 years ago

samponeill commented 3 years ago

Adding a webapp as a related application gives me the following:

whereas w3c options include: "chrome_web_store": Google Chrome Web Store. "play": Google Play Store. "itunes": iTunes App Store. "webapp": Web apps. "windows": Windows App Store.

https://github.com/w3c/manifest/wiki/Platforms

Is it possible to add the above options and disable the requirement for id for webapps?

LekoArts commented 3 years ago

Thank you for opening this!

As per the W3 spec you need to have an id or url: https://www.w3.org/TR/appmanifest/#externalapplicationresource-and-its-members

So our error logging is working as expected here.

We're marking this issue as answered and closing it for now but please feel free to comment here if you would like to continue this discussion. We also recommend heading over to our communities if you have questions that are not bug reports or feature requests. We hope we managed to help and thank you for using Gatsby!

samponeill commented 3 years ago

@LekoArts thanks for taking the time to respond

Please can you address the platforms issue? Webapp is a known possible value according to the wiki but is not being allowed here

samponeill commented 3 years ago

@LekoArts thanks for adding that in!

As for id – you say I need an id or url and I have a url but I'm still encountering an error message saying I need an id. Should it be url or id rather than requiring id no matter what?

"A valid ExternalApplicationResource dictionary MUST have platform and either an url or an id (or both)." from W3 spec you referenced (emphasis mine)