gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.2k stars 10.33k forks source link

gatsby-plugin-netlify-cms using deprecated cms package #38553

Closed ErikAGriffin closed 9 months ago

ErikAGriffin commented 1 year ago

Preliminary Checks

Description

The plugin gatsby-plugin-netlify-cms is referencing the deprecated package for the decap-cms-app.

Netlify CMS has become Decap CMS, and as such Netlify is no longer the maintainer and many of the core package names have been updated to reflect this.

The gatsby-plugin-netlify-cms does not list netlify-cms-app as a dependency, although it requires it to be installed by importing it in code. If the user does install netlify-cms-app, they will be receiving version 2.15.72, which is out of date with the now maintained decap-cms-app package which is currently on version 3.0.7.


Therefore I plan to open the following Pull Request: adding a deprecation note to the README of gatsby-plugin-netlify-cms, and essentially cloning it to a new package in the Gatsby monorepo titled gatsby-plugin-decap-cms, which updates the reference to the decap core packages correctly.

Reproduction Link

https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-netlify-cms/src/cms.js#L1

Steps to Reproduce

  1. Read the code in the link provided.

Expected Result

The plugin imports decap-cms-app

Actual Result

The plugin imports netlify-cms-app

Environment

N/A

Config Flags

No response

ErikAGriffin commented 1 year ago

Related pull request: https://github.com/gatsbyjs/gatsby/pull/38554

ErikAGriffin commented 9 months ago

https://github.com/decaporg/gatsby-plugin-decap-cms