search

gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.2k stars 10.33k forks source link

Site Showcase #4392

Closed calcsam closed 6 years ago

calcsam commented 6 years ago

One of the most powerful demonstrations of Gatsby is clicking around sites, for example on the current showcase list and seeing how fast they are.

Following up on the heels of the recently merged in package library, we should add a site showcase to gatsbyjs.org to do this in a more powerful way, including:

shannonbux commented 6 years ago

Ok I agree with those ways of determining which sites are previous/next.

The modal looks excellent to,@fk!

On Mon, Apr 30, 2018 at 10:45 AM Florian Kissling notifications@github.com wrote:

In the detail view, what list do the "prev" and "next" sites belong to? Featured sites, alphabetical list, etc.? I wasn't sure.

@shannonbux https://github.com/shannonbux That's another good question that I've been wondering about myself while working on the new modal view as well as as preparing the "Mobile" prototype.

The "Featured Sites" section on the "Showcase" index page makes things a bit more complicated than they need to be. If we want to keep it, I'd suggest the following:

  1. When viewing the details for a site listed in the "Featured Sites" section on the "Showcase" index page, the previous/next links IMO should show the previous/next site from the "Featured Sites" section list — at least that's what I'd expect as a user. That said, we would need to decide wether to allow browsing through all sites in the "Featured" category, or just the sites listed in the "Featured Sites" section (e.g. ten), and show the "View all featured Sites" card as last item (e.g. after the tenth item). Clearly leaning towards the latter here.
  2. When viewing the details for a site listed in the "All Sites in Showcase" section, previous/next should show the previous/next site in the list, reflect the current filter and sort settings.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gatsbyjs/gatsby/issues/4392#issuecomment-385457091, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae9o2kK23GCpIeqlDbvJiiZ-GHXCJuIbks5ttz-lgaJpZM4SfWNe .

fk commented 6 years ago

@shannonbux 👍 , will follow up with a matching detail view for Desktop!

fk commented 6 years ago

Here's the updated detail view for Desktop:

desktop hd detail view permalink

Updated Sketch file: https://www.dropbox.com/s/9vzatfift5oz69b/gatsbyjs.org%3Ashowcase.v2.sketch

swyxio commented 6 years ago

hello im new here - it looks like the design is more or less done and just waiting for some dev time? has anyone started on this? (also I don't have sketch so this is gonna be tricky)

daydream05 commented 6 years ago

Would also love to help with the development of this!

shannonbux commented 6 years ago

@sw-yx did you see that @ThatOtherPerson referenced this issue and has built most of the functionality? We would love for your feedback and help!

swyxio commented 6 years ago

just saw! nice job!

shannonbux commented 6 years ago

Closed and moved next phases to Issue #5927