gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.3k stars 10.31k forks source link

[www] Bugs on new /packages library #4411

Closed LekoArts closed 6 years ago

LekoArts commented 6 years ago

@fk I encountered some issues on the new library page on my iPhone. Made a video for you đź‘Ť

https://drive.google.com/open?id=1Z1xytCEVPd3KGvJtr3-tisZ15DAF7W5Q

On desktop:

fk commented 6 years ago

Thank you Lennart, will take a look now!

fk commented 6 years ago

Here's another bug reported via Twitter: https://twitter.com/ARasheedPhoto/status/971407215553781761

fk commented 6 years ago

If I select an item and press the "Load More" the content in the middle vanishes. It should stay there and only change if I select another package

fk commented 6 years ago

@KyleAMathews just fixed package search displaying the default landing page when altering the search query/loading more results in #4427. Will look into the scroll issue now.

fk commented 6 years ago

4436 hopefully addresses the most crucial of the issues you reported @LeKoArts: "Load more" and the Algolia credits show up on mobile, and the Mobile Safari overscroll issue is fixed.

In regards to @andrew-codes/gatsby-plugin-elasticlunr-search I don't think there's much we can/should do—@andrew-codes simply is part of the package name: https://www.npmjs.com/package/@andrew-codes/gatsby-plugin-elasticlunr-search

Not sure how to polish the "Load more" button…more ;-) given the markup provided by react-instantsearch—maybe you want to give that a shot?