search

gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.27k stars 10.31k forks source link

Request: First-Class Storybook Integration #7219

Closed Undistraction closed 5 years ago

Undistraction commented 6 years ago

Summary

It is currently pretty painful to integrate Storybook with Gatsby. I know there is some discussion here and there is a great starter here, but imho, storybook should be something that works out the box (or as close to it as possible). This could be in the form of an official plugin, but I personally think this should be fully integrated so users are provided out-of-the-box with:

madeleineostoja commented 6 years ago

👍 This would be great, but I think it should be provided as an official plugin rather than baked in. It's a rather opinionated feature, when there are other component library helpers out there that people might prefer to use.

EDIT: Just looked into that starter, looks like the kind of rigmarole you have to setup for hacking around Gatsby wouldn't be doable as a plugin. So yep would be awesome to have some kind of out-of-the-box support for this. Looks like Storybook is working on a concept of presets, if this becomes a thing adding a Gatsby one would be a no-brainer

Undistraction commented 6 years ago

@seaneking Yes. I think ideally it would be a plugin, but it goes too deep (at least with the current API) for that to be viable.

I'm working on a new project at the moment with Gatsby and Styled Components hooked up to Storybook and backed by Jest tests and it really feels like its the promised land to me. We are going to take a look at integrating Chromatic which I think will be the icing on the cake.

LekoArts commented 5 years ago

There's a guide for Storybook now: https://www.gatsbyjs.org/docs/visual-testing-with-storybook/

gatsbot[bot] commented 5 years ago

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

madeleineostoja commented 5 years ago

Would be great to keep this open — the Gatsby Babel preset helped, but there's still a fair few hacky workarounds needed to get Storybook working, would be great to see if we can get tighter integration out of the box

gatsbot[bot] commented 5 years ago

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

gatsbot[bot] commented 5 years ago

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!