Closed jlengstorf closed 6 years ago
I'll take care of it ππΌ
Can we run a link checker to make sure we're not missing anything once this is done?
Update robots.txt temporarily so we can run the broken link checker.
https://github.com/stevenvachon/broken-link-checker seems to work locally with current robots.txt
currently running it with blc -g -r -f -e https://next.gatsbyjs.org
(recursively + only internal links) and it produces:
Getting links from: https://next.gatsbyjs.org/docs/
...
ββββOKβββ https://next.gatsbyjs.org/docs/post-css/
ββββOKβββ https://next.gatsbyjs.org/docs/testing/
ββBROKENβ https://next.gatsbyjs.org/docs/unit-testing/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/testing-components-with-graphql/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/end-to-end-testing/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/testing-css-in-js/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/testing-react-components/ (HTTP_404)
ββββOKβββ https://next.gatsbyjs.org/docs/debugging/
ββββOKβββ https://next.gatsbyjs.org/docs/debugging-html-builds/
Just after a while I'm getting some ERRNO_ECONNRESET
which I think my connection can't handle all the concurrent requests
All right, I probably tried to do too much - here are broken links from /docs
page (with some false negatives because of my connection) - but enough to spot actual broken links
Getting links from: https://next.gatsbyjs.org/docs/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-starters/
ββββOKβββ https://next.gatsbyjs.org/docs/recipes/
ββββOKβββ https://next.gatsbyjs.org/docs/overview/
ββββOKβββ https://next.gatsbyjs.org/docs/preparing-your-environment/
ββββOKβββ https://next.gatsbyjs.org/docs/basic-hardware-software-requirements/
ββββOKβββ https://next.gatsbyjs.org/docs/browser-support/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-on-macs/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-on-windows/
ββββOKβββ https://next.gatsbyjs.org/docs/deploying-and-hosting/
ββββOKβββ https://next.gatsbyjs.org/docs/preparing-for-deployment/
ββββOKβββ https://next.gatsbyjs.org/docs/deploy-gatsby/
ββββOKβββ https://next.gatsbyjs.org/docs/path-prefix/
ββββOKβββ https://next.gatsbyjs.org/docs/how-gatsby-works-with-github-pages/
ββββOKβββ https://next.gatsbyjs.org/docs/customization/
ββββOKβββ https://next.gatsbyjs.org/docs/babel/
ββββOKβββ https://next.gatsbyjs.org/docs/add-custom-webpack-config/
ββββOKβββ https://next.gatsbyjs.org/docs/custom-html/
ββββOKβββ https://next.gatsbyjs.org/docs/environment-variables/
ββββOKβββ https://next.gatsbyjs.org/docs/api-proxy/
ββββOKβββ https://next.gatsbyjs.org/docs/images-and-files/
ββββOKβββ https://next.gatsbyjs.org/docs/adding-images-fonts-files/
ββββOKβββ https://next.gatsbyjs.org/docs/static-folder/
ββββOKβββ https://next.gatsbyjs.org/docs/dropping-images-into-static-folders/
ββββOKβββ https://next.gatsbyjs.org/docs/importing-single-files/
ββββOKβββ https://next.gatsbyjs.org/docs/importing-media-content/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-source-filesystem-programmatic-import/
ββββOKβββ https://next.gatsbyjs.org/docs/working-with-images/
ββββOKβββ https://next.gatsbyjs.org/docs/content-and-data/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-the-filesystem/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-databases/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-saas-services/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-private-apis/
ββββOKβββ https://next.gatsbyjs.org/docs/headless-cms/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-netlify-cms/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-wordpress/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-drupal/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-contentful/
ββββOKβββ https://next.gatsbyjs.org/docs/sourcing-from-prose/
ββββOKβββ https://next.gatsbyjs.org/docs/graphql/
ββββOKβββ https://next.gatsbyjs.org/docs/introducing-graphiql/
ββββOKβββ https://next.gatsbyjs.org/docs/creating-and-modifying-pages/
ββββOKβββ https://next.gatsbyjs.org/docs/page-query/
ββββOKβββ https://next.gatsbyjs.org/docs/static-query/
ββββOKβββ https://next.gatsbyjs.org/docs/adding-markdown-pages/
ββββOKβββ https://next.gatsbyjs.org/docs/adding-a-list-of-markdown-blog-posts/
ββββOKβββ https://next.gatsbyjs.org/docs/creating-slugs-for-pages/
ββββOKβββ https://next.gatsbyjs.org/docs/programmatically-create-pages-from-data/
ββββOKβββ https://next.gatsbyjs.org/docs/plugins/
ββββOKβββ https://next.gatsbyjs.org/docs/plugin-authoring/
ββββOKβββ https://next.gatsbyjs.org/docs/submit-to-plugin-library/
ββββOKβββ https://next.gatsbyjs.org/docs/source-plugin-tutorial/
ββββOKβββ https://next.gatsbyjs.org/docs/styling/
ββββOKβββ https://next.gatsbyjs.org/docs/css-modules/
ββββOKβββ https://next.gatsbyjs.org/docs/typography-js/
ββββOKβββ https://next.gatsbyjs.org/docs/glamor/
ββββOKβββ https://next.gatsbyjs.org/docs/styled-components/
ββββOKβββ https://next.gatsbyjs.org/docs/creating-global-styles/
ββββOKβββ https://next.gatsbyjs.org/docs/component-css/
ββββOKβββ https://next.gatsbyjs.org/docs/post-css/
ββββOKβββ https://next.gatsbyjs.org/docs/testing/
ββBROKENβ https://next.gatsbyjs.org/docs/unit-testing/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/testing-components-with-graphql/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/end-to-end-testing/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/testing-css-in-js/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/testing-react-components/ (HTTP_404)
ββββOKβββ https://next.gatsbyjs.org/docs/debugging/
ββββOKβββ https://next.gatsbyjs.org/docs/debugging-html-builds/
ββββOKβββ https://next.gatsbyjs.org/docs/debugging-replace-renderer-api/
ββββOKβββ https://next.gatsbyjs.org/docs/debugging-the-build-process/
ββββOKβββ https://next.gatsbyjs.org/docs/performance-tracing/
ββββOKβββ https://next.gatsbyjs.org/docs/building-apps-with-gatsby/
ββββOKβββ https://next.gatsbyjs.org/docs/progressive-web-app/
ββββOKβββ https://next.gatsbyjs.org/docs/creating-dynamically-rendered-navigation/
ββββOKβββ https://next.gatsbyjs.org/docs/authentication/
ββββOKβββ https://next.gatsbyjs.org/docs/e-commerce/
ββββOKβββ https://next.gatsbyjs.org/docs/interactive-pages/
ββββOKβββ https://next.gatsbyjs.org/docs/preparing-for-site-launch/
ββββOKβββ https://next.gatsbyjs.org/docs/add-404-page/
ββBROKENβ https://next.gatsbyjs.org/docs/adding-search/ (ERRNO_ECONNRESET)
ββββOKβββ https://next.gatsbyjs.org/docs/adding-tags-and-categories-to-blog-posts/
ββββOKβββ https://next.gatsbyjs.org/docs/creating-a-sitemap/
ββββOKβββ https://next.gatsbyjs.org/docs/linking-between-pages/
ββββOKβββ https://next.gatsbyjs.org/docs/seo/
ββBROKENβ https://next.gatsbyjs.org/docs/adding-third-party-services/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/adding-search/ (HTTP_undefined)
ββBROKENβ https://next.gatsbyjs.org/docs/adding-analytics/ (HTTP_404)
ββBROKENβ https://next.gatsbyjs.org/docs/adding-forms/ (HTTP_404)
ββββOKβββ https://next.gatsbyjs.org/docs/performance/
ββββOKβββ https://next.gatsbyjs.org/docs/caching/
ββββOKβββ https://next.gatsbyjs.org/docs/local-https/
ββββOKβββ https://next.gatsbyjs.org/docs/lighthouse-audit/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-link/
ββββOKβββ https://next.gatsbyjs.org/docs/node-apis/
ββββOKβββ https://next.gatsbyjs.org/docs/browser-apis/
ββββOKβββ https://next.gatsbyjs.org/docs/ssr-apis/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-config/
ββββOKβββ https://next.gatsbyjs.org/docs/actions/
ββββOKβββ https://next.gatsbyjs.org/docs/graphql-reference/
ββββOKβββ https://next.gatsbyjs.org/docs/node-interface/
ββββOKβββ https://next.gatsbyjs.org/docs/api-specification/
ββββOKβββ https://next.gatsbyjs.org/docs/v2-release-notes/
ββββOKβββ https://next.gatsbyjs.org/docs/v1-release-notes/
ββββOKβββ https://next.gatsbyjs.org/docs/v0-release-notes/
ββββOKβββ https://next.gatsbyjs.org/docs/migrating-from-v1-to-v2/
ββββOKβββ https://next.gatsbyjs.org/docs/migrating-from-v0-to-v1/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-core-philosophy/
ββββOKβββ https://next.gatsbyjs.org/docs/life-and-times-of-a-gatsby-build/
ββββOKβββ https://next.gatsbyjs.org/docs/building-with-components/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-lifecycle-apis/
ββββOKβββ https://next.gatsbyjs.org/docs/prpl-pattern/
ββββOKβββ https://next.gatsbyjs.org/docs/querying-with-graphql/
ββββOKβββ https://next.gatsbyjs.org/docs/authentication-tutorial/
ββββOKβββ https://next.gatsbyjs.org/docs/ecommerce-tutorial/
ββββOKβββ https://next.gatsbyjs.org/docs/wordpress-source-plugin-tutorial/
ββββOKβββ https://next.gatsbyjs.org/docs/image-tutorial/
ββββOKβββ https://next.gatsbyjs.org/docs/community/
ββββOKβββ https://next.gatsbyjs.org/docs/code-of-conduct/
ββββOKβββ https://next.gatsbyjs.org/docs/how-to-contribute/
ββββOKβββ https://next.gatsbyjs.org/docs/contributor-swag/
ββββOKβββ https://next.gatsbyjs.org/docs/how-to-file-an-issue/
ββββOKβββ https://next.gatsbyjs.org/docs/how-to-label-an-issue/
ββββOKβββ https://next.gatsbyjs.org/docs/how-to-submit-a-pr/
ββββOKβββ https://next.gatsbyjs.org/docs/pair-programming/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-style-guide/
ββββOKβββ https://next.gatsbyjs.org/docs/design-principles/
ββββOKβββ https://next.gatsbyjs.org/docs/rfc-process/
ββββOKβββ https://next.gatsbyjs.org/docs/templates/
ββββOKβββ https://next.gatsbyjs.org/docs/how-to-run-a-gatsby-workshop/
ββββOKβββ https://next.gatsbyjs.org/docs/how-to-pitch-gatsby/
ββββOKβββ https://next.gatsbyjs.org/docs/submit-a-blogpost/
ββββOKβββ https://next.gatsbyjs.org/docs/site-showcase-submissions/
ββββOKβββ https://next.gatsbyjs.org/docs/submit-to-starter-showcase/
ββββOKβββ https://next.gatsbyjs.org/docs/glossary/
ββββOKβββ https://next.gatsbyjs.org/docs/gatsby-cli/
Finished! 189 links found. 55 excluded. 10 broken.
Great! Thanks for this, @pieh!
It took 30 minutes, but I got the full site output from that tool, if anyone is interested.
https://gist.github.com/amberleyromo/78ad2efaabeac53208626a16b8b7e047
I have what I need for the docs work though. Thanks y'all
@amberleyromo Seems like the list has a lot of Broken links. Happy to help if you need! :)
We'd love to have your help, @kartiklad! I'm not sure that everything in @amberleyromo's report is actually broken; I think that tool sent back a lot of false positives. The checklist at the top of this issue is a better starting point.
Thanks so much for contributing! πͺπ
Awesome! Iβll get on it and send a PR soon...cheers!
These ones should all work now and I've updated the checklist at the top of the issue:
ββBROKENβ https://next.gatsbyjs.org/docs/unit-testing/ (HTTP_404) ββBROKENβ https://next.gatsbyjs.org/docs/testing-components-with-graphql/ (HTTP_404) ββBROKENβ https://next.gatsbyjs.org/docs/end-to-end-testing/ (HTTP_404) ββBROKENβ https://next.gatsbyjs.org/docs/testing-css-in-js/ (HTTP_404) ββBROKENβ https://next.gatsbyjs.org/docs/testing-react-components/ (HTTP_404)
On Fri, Aug 17, 2018 at 1:39 AM, Kartik Lad notifications@github.com wrote:
Awesome! Iβll get on it and send a PR soon...cheers!
β You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gatsbyjs/gatsby/issues/7294#issuecomment-413784249, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae9o2nER0i0CcdthEZlsmPrcB1mW-0daks5uRnMjgaJpZM4V7dsW .
Looks like the "Adding Third Party Services" overview and its children are the only things broken. Also, "Adding Search" exists, but in a different section of the docs! We need to just move it to "Adding Third Party Services", I suppose. I'm not sure if that's the right choice.
@jlengstorf, the "Sourcing content and data" section works for me. Does it still not work for you?
Also, wondering if we ought to rename https://next.gatsbyjs.org/docs/headless-cms/ to "Sourcing from Headless CMSs" <--does that pluralization bother anyone else on a nav bar? It's not my favorite. We could do "Sourcing from a Headless CMS". Once we agree on whether/which title change to do, I can do it and then add a redirect.
@shannonbux I think "Sourcing from a Headless CMS" sounds better
Hey @shannonbux @jlengstorf,
Just made a pull request(#7432) to add the missing pages and also moved the Adding search page to 3rd party services. Hope it's ok?
Looks great, @kartiklad β merged! Thanks so much for your help! πͺπ
There are several docs I've found that are defined in
doc-links.yaml
as stubs, but that don't have corresponding stub Markdown files. For example, I'm pretty sure none of the stubs under "Sourcing Content and Data" exist.We need to do a once-over to ensure that the stubs exist to avoid 404s.
Docs that need to be created:
/docs/docs/unit-testing.md
/docs/docs/testing-components-with-graphql.md
/docs/docs/end-to-end-testing.md
/docs/docs/testing-css-in-js.md
/docs/docs/testing-react-components.md
/docs/docs/adding-search.md
/docs/docs/adding-third-party-services.md
/docs/docs/adding-analytics.md
/docs/docs/adding-forms.md
The stub template is here:
https://github.com/gatsbyjs/gatsby/blob/151b1f9a7e1dac890779941db24eff9f35900b8c/docs/docs/authentication-tutorial.md
For anyone who'd like to open a PR, you can add one or more of these stubs in a pull request. This is a great way for first-timers to get involved!
cc: @shannonbux @amberleyromo @kkemple