search

gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.
https://www.gatsbyjs.com
MIT License
55.19k stars 10.33k forks source link

[starter library] Gatsby starter page crashes on site #8757

Closed rgbkrk closed 5 years ago

rgbkrk commented 5 years ago

Description

Loading everything on the Gatsby starter page listing (https://www.gatsbyjs.org/starters/) crashes, ends up with a white screen.

load more and crash

Steps to reproduce

  1. Open https://www.gatsbyjs.org/starters/
  2. Scroll to bottom, click "Load More"
  3. Repeat Step 2 until crash (~4 times)

Expected result

All content to be loaded (and no more ability to load more content). At the very least though, an error boundary implemented at the page level that would make reporting this easier.

Actual result

screen shot 2018-10-03 at 7 11 13 am

rgbkrk commented 5 years ago

Ran devtools again and pre-emptively caught the exception. Looks like this is the bad data:

starter = {id: "7494ca33-38f1-5185-9cd3-3d9d3e9d5cee", fields: null, url: "http://gatsbyjs.github.io/gatsby-starter-default/", repo: "https://github.com/gatsbyjs/gatsby-starter-default", description: "official default", …}

screen shot 2018-10-03 at 7 37 13 am

axhon commented 5 years ago

I wasn't sure if this needs to be its own issue or not so if it does please just holler.

The same error occurs when certain filters from the "Categories" section are selected.

The current list is as follows: NetlifyCMS PWA Disqus Styling:Bulma

I haven't tested the "Gatsby Dependencies" section.

Steps to Reproduce

  1. Open https://www.gatsbyjs.org/starters/
  2. Select one of the items on list

Expected Result

The page to load items based on selected filter

Actual Result

image

chmac commented 5 years ago

It looks like this is a slightly inconsistent problem. In the current starter list every starter except the last one in the list has a starterShowcase value.

Reading the code that generates these fields, it looks like the field should always be created. It's not clear to me how a starter gets into the list without having the starterShowcase field added.

https://github.com/gatsbyjs/gatsby/blob/b5cb862f686dca3cf261ce72ede453ae800efc5c/www/gatsby-node.js#L447-L561

amberleyromo commented 5 years ago

Hi @chmac -- it's not clear to me either. If you want to take a look at the current PR to address this issue, feel free -- #8763

I'm not sure why it's happening, part of that PR is just a stopgap for the problem.