[starter-library] "Submit a Starter" button is broken

gatsbyjs / gatsby

The best React-based framework with performance, scalability and security built in.

https://www.gatsbyjs.com

MIT License

55.14k stars 10.33k forks source link

[starter-library] "Submit a Starter" button is broken #8968

Closed Manoz closed 5 years ago

Manoz commented 5 years ago

Description

The Submit a Starter button is a bit broken on mobile version.

Steps to reproduce

Take a look at the starters page on your smartphone or on mobile resolution with your dev tools.

Expected result

I have no idea. What should we do? Since the block with the title and the search form are sticky on scroll what should we do? Hide the button on mobile?

screenshot-2018-10-09_23-12-53

Actual result

submit-a-starter

Environment

System:
  OS: Windows 10
  Mobile OS: iOS 12.1 Public beta 3
Binaries:
  Yarn: 1.9.4
  npm: 6.3.0
Browsers:
  Google Chrome: 69.0.3497.100
  Google Chrome on iPhone (latest version)
  Safari on iOS (latest version)

lmcjt37 commented 5 years ago

Happy to pick this up?

How likely is it that anyone would want to 'submit a starter' via their mobile device? I would suggest this be hidden for mobile

kakadiadarpan commented 5 years ago

In my opinion, we should fix the CSS.

@pieh what do you think about this?

Manoz commented 5 years ago

@lmcjt37 there's a PR already :) The button is actually a link to the documentation page so it might be useful on mobile too

tanvibhakta commented 5 years ago

Here's the PR for those interested: https://github.com/gatsbyjs/gatsby/pull/8969

It looks like discussion has stalled on that thread. Can we add a claimed label to this bug as well?

Manoz commented 5 years ago

@tanvibhakta This is not part of the Hacktoberfest but why not :p

amberleyromo commented 5 years ago

Fixed in #10567.