Introduce WordPress VIP coding standards and fixes for existing errors

[henrikwirth]

See this ticket as a main reference and for discussions: https://github.com/wp-graphql/wp-graphql/issues/1535

WordPress VIP has pretty high coding standards and everyone who will work with VIP in the future will face the same problems as our team right now. It would be great if we could get coding standards up and running with VIP's standards.

Ideally we could setup PHP_Codesniffer with all the configurations of them and let a bot check run through it before merging PRs.

We will attempt to setup everything and also fix major errors, so that we will be able to use WPGraphQL in the future. It would be great if some maintainers can share some of their attention on this, so we don't end up breaking stuff.

Also this is obviously open for discussion, we would just use that PR for our purposes anyways, but would greatly appreciate if it would make it into the main repos best practices.

References:

• https://wpvip.com/documentation/how-to-install-php-code-sniffer-for-wordpress-vip/
• https://github.com/Automattic/VIP-Coding-Standards/tree/master/WordPress-VIP-Go

[emaildano]

Could be as easy as adding a GitHub action and loading the VIP Coding Standards.

https://github.com/marketplace/actions/php_codesniffer-check-with-annotations

[TylerBarnes]

I'm all for this! I've actually left out a lot of these types of things because the original plan was for @jasonbahl to come in and own this plugin after I did the initial prototype, but he hasn't had time yet due to shipping WPGraphQL 1.0. I'll take a look at adding that GH action because that'd be really nice.

[TylerBarnes]

I chatted with @jasonbahl about this and he wants to own it still so I'll leave it to him 👍