search

gattia / pyfocusr

MIT License
7 stars 0 forks source link

Update FOCUSR object to make parameters callable #5

Open gattia opened 2 years ago

gattia commented 2 years ago

https://github.com/gattia/pyfocusr/blob/9cd8669c9595365653469c762638bebc2c49323f/pyfocusr/focusr.py#L15

Update paramaeters like:

to be dynamically updateable by using:

focusr.icp_register_first = True

And the same for retrieving information:

print(focusr.icp_register_first)

but use proper @property instead of directly accessing that information from the object.

gattia commented 2 years ago

Same for other things: https://github.com/gattia/pyfocusr/blob/9cd8669c9595365653469c762638bebc2c49323f/pyfocusr/focusr.py#L497-L517

The above shows how we are setting / updating certain parametres - should consolidate. Should also change objects like self.weighted_avg_transformed_mesh to be self._weighted_avg_transformed_mesh so that we arent messing with it directly. Also, self.weighted_avg_transformed_mesh & self.nearest_neighbour_transformed_mesh should probably just be the same thing and not be accessing different object/things.