gaucho-labs / leptos-hotkeys

a declarative way of using keyboard shortcuts + callbacks in leptos applications
https://leptos-hotkeys.vercel.app
MIT License
43 stars 8 forks source link

Refactor in #104 broke #108 keycode handling fix. #116

Closed zakstucke closed 2 months ago

zakstucke commented 2 months ago

104 was applied after #108, reverting its fix in some way.

   // Won't fire after #104
    use_hotkeys!(("control+keyk") => move |_| {
        tracing::info!("PRESSED!");
    });

Commit: ad8fa5774c6bfe254b128d2358b706e570c87389 (#104) broken Commit: e135560ccdcfbb66888a219e6bcb95f02f068048 (commit prior) working

Ever since #108 I'd been using that specific git hash (waiting for a release), just updated to the new release and realised.

friendlymatthew commented 2 months ago

@zakstucke thanks!

friendlymatthew commented 2 months ago

@zakstucke can I get your discord? You can add me matteobacalao

friendlymatthew commented 2 months ago

Closed via #117