Support file globbing in exclude_paths

gauge-sh / tach

A Python tool to enforce dependencies, using modular architecture 🌎 Open source 🐍 Installable via pip 🔧 Able to be adopted incrementally - ⚡ Implemented with no runtime impact ♾️ Interoperable with your existing systems 🦀 Written in rust

https://gauge.sh

MIT License

664 stars 23 forks source link

Support file globbing in exclude_paths #124

Open emdoyle opened 4 weeks ago

emdoyle commented 4 weeks ago

As mentioned in #101, it's confusing that exclude_paths uses regex instead of file globbing.

Conceptually, this behavior should match that of other linters like ruff. Using that example, it makes sense to support globset: https://docs.astral.sh/ruff/settings/#exclude https://docs.rs/globset/latest/globset/#syntax

This will require updating the docs to explain the new behavior.

shreyash2002 commented 3 weeks ago

hey @emdoyle I would love to work on this issue. since, its good first issue 👍

emdoyle commented 3 weeks ago

hey @emdoyle I would love to work on this issue. since, its good first issue 👍

Sounds great! Feel free to put up a PR any time, and ask me if anything is unclear.

emdoyle commented 1 week ago

@shreyash2002 is this still something you'd like to work on? Otherwise I'll unassign so that someone else can pick it up.