search

gauge-sh / tach

A Python tool to enforce dependencies, using modular architecture 🌎 Open source 🐍 Installable via pip 🔧 Able to be adopted incrementally - ⚡ Implemented with no runtime impact ♾️ Interoperable with your existing systems 🦀 Written in rust
https://gauge.sh
MIT License
953 stars 33 forks source link

Fix deps make function, activate venv before installing crate #186

Closed letmerecall closed 1 month ago

letmerecall commented 1 month ago

What's new in this PR?

Fixes #185

Makefile rule is executed in it's own subshell. Therefore, the activation of the virtual environment in the line with source $(VENV_BIN)/activate was not affecting the subsequent line.

letmerecall commented 1 month ago

@emdoyle Maybe a good idea to update CI workflow, like this step, and use make functions? Could be a good test for those functions.

emdoyle commented 1 month ago

@emdoyle Maybe a good idea to update CI workflow, like this step, and use make functions? Could be a good test for those functions.

Yup, that's a great idea. I'll do a pass on the CI action, there are a few other things that change in #183