search

gaul / s3proxy

Access other storage backends via the S3 API
Apache License 2.0
1.65k stars 220 forks source link

Add DELETE and HEAD methods for CORS and CORS headers for all responses #565

Closed jixinchi closed 8 months ago

jixinchi commented 8 months ago

  1. I found that DELETE method is not supported for CORS, which should be included. Refer to: aws CORS config

  2. Currently, not all handle methods include "addCorsResponseHeader". I add it in all handle methods, because in most cases, the browser needs it.

gaul commented 8 months ago

@reimannf could you look at this?

reimannf commented 8 months ago

LGTM. Only one nitpick to update the README here: https://github.com/gaul/s3proxy/blob/master/README.md?plain=1#L148

jixinchi commented 8 months ago

Thanks! I have updated the README.

gaul commented 8 months ago

Thank you for your contribution @jixinchi!