search

gaul / s3proxy

Access other storage backends via the S3 API
Apache License 2.0
1.65k stars 220 forks source link

add missing pipe-character for images in meta step #595

Closed snpz closed 5 months ago

snpz commented 5 months ago

Hi @gaul.

As promised I had another look and I missed the pipe character in the images-definition which leads to ignored newlines which then produce the wrong outputs in the meta step. (I tested locally in a private repo and copied my changes to the fork afterwards, i must have missed this one)

Wrong version from the failed action log including "name" from line 35 before ,enable=true:

Processing images input
  name=ghcr.io/gaul/s3proxy/container name,enable=true

How it should look

Processing images input
  name=ghcr.io/gaul/s3proxy/container,enable=true

The automatic build triggered through this PR looks correct this time, feel free to mention me if it doesn't.

Not quite sure yet, but chances are high I will try to fix those warnings too - they bother me somehow. :)

gaul commented 5 months ago

Thanks for your continued investigation of this.

gaul commented 5 months ago

This appears to be correctly pushing again:

https://hub.docker.com/r/andrewgaul/s3proxy/tags