search

gauntface / dpad-navigation

A javascript library to add basic spatial navigation to your web app. Useful until spatial focusing becomes the norm in browsers
Apache License 2.0
61 stars 15 forks source link

Fix update call duplication issue #19

Closed jaredbrowarnik closed 2 years ago

jaredbrowarnik commented 2 years ago

Noticed an issue where performance would degrade significantly if update was called frequently. This is because the update call does not clear out the focusableItems array, so it would contain many duplicates of items and the updateNeighbors calls for all of these items would take a long time to run (> 1 sec) leading to the app lagging.

gauntface commented 2 years ago

Thank you for this, really appreciate it.

gauntface commented 2 years ago

Changes published in @gauntface/dpad-nav@3.0.2