Very minor fixes required to support current FF Nightly (48)

gauntface / web-push-go

Apache License 2.0

99 stars 14 forks source link

Very minor fixes required to support current FF Nightly (48) #1

Closed wibblymat closed 8 years ago

wibblymat commented 8 years ago

R: @crhym3 @gauntface

@crhym3 I found a more elegant solution in the end

I successfully sent a push with payload to FF for the first time today. FF has the correct behaviour according to the spec.

A fix to the bug in Chrome is out for review but won't land until 51 at least, probably 52 because the branch point has already gone.

x1ddos commented 8 years ago

I don't suppose there a test for SubscriptionFromJSON? Ideally, you'd try to call it with different inputs and verify the output, or the error at least.

wibblymat commented 8 years ago

Good call, will do.

wibblymat commented 8 years ago

@crhym3 PTAL

x1ddos commented 8 years ago

Nice. LGTM :star2: