Add Vapid support and assorted fixes

gauntface / web-push-go

Apache License 2.0

99 stars 14 forks source link

Add Vapid support and assorted fixes #11

Closed costinm closed 7 years ago

costinm commented 8 years ago

The 'integration' tests are passing, but likely to fail when the subscriptions expire - a more 'end-to-end' solution that includes registration is needed.

wibblymat commented 8 years ago

Hi @costinm! Sorry for wait due to the long weekend. Reviewing now.

wibblymat commented 8 years ago

@surma, since I'm not a Go master

surma commented 8 years ago

A few remarks from my side, agree with all of @wibblymat’s feedback.

gauntface commented 7 years ago

Closing this pull request - it's too large and covering too many changes to merge.