Closed costinm closed 7 years ago
Hi @costinm! Sorry for wait due to the long weekend. Reviewing now.
@surma, since I'm not a Go master
A few remarks from my side, agree with all of @wibblymat’s feedback.
Closing this pull request - it's too large and covering too many changes to merge.
The 'integration' tests are passing, but likely to fail when the subscriptions expire - a more 'end-to-end' solution that includes registration is needed.