Fixes #12, #13, #14 - Githubissues

gauntface / web-push-go

Apache License 2.0

99 stars 14 forks source link

Closed wibblymat closed 8 years ago

wibblymat commented 8 years ago

R: @gauntface @crhym3 CC: @pinarx

wibblymat commented 8 years ago

@crhym3 whoops, pushed the commit but forgot to say "PTAL"

x1ddos commented 8 years ago

Sorry, should've looked at it sooner. It's much better now! Just a couple nits but I'm really glad there's no change in exported functions.

wibblymat commented 8 years ago

Ok, PTAL. I'd made the same mistake with the expected/actual values being flipped in a bunch of other places, too.

x1ddos commented 8 years ago

LGTM