Aes128gcm support - Githubissues

pinarx commented 7 years ago

Add support for aes128gcm changes.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

pinarx commented 7 years ago

signed

googlebot commented 7 years ago

CLAs look good, thanks!

x1ddos commented 7 years ago

Just an indentation nit. Probably needs to be feeded to gofmt again. It's a good practice run it every time on save.

@gauntface I wonder where Travis CI results though. Can't see them here in the PR.

x1ddos commented 7 years ago

Ah, @gauntface I know why. You still need to submit your #22.

gauntface / web-push-go

Aes128gcm support #19