search

gauntface / web-push-go

Apache License 2.0
99 stars 14 forks source link

variable TTL with signature change in Send function #8

Closed ishail closed 8 years ago

ishail commented 8 years ago

Signature change in Send function so that this function can take TTL as variable along with few more variables such as content_available, collapse_key, etc defined at gcm http-server-ref.

codescrapper commented 8 years ago

Looks okay.

wibblymat commented 8 years ago

Sorry for the long delay. As I understand it, changing function signatures in published Go libraries is bad, because there is no version management.

However, we did actually think about the need for an extension point, which is why the NewPushRequest function was separated out of Send. Call NewPushRequest and then manipulate the headers of that request, then send it yourself.