gaurav-arya / ImagingOpt.jl

MIT License
7 stars 1 forks source link

a error #20

Open fsfing opened 1 year ago

fsfing commented 1 year ago

Hello, friend.

I configured the environment ok last time, but I ran it again today and found a new problem.

ERROR: LoadError: UndefVarError: state not defined

In line 118 of optimize.jl "st = Optimisers.state(opt, (PSFs, logα / hyperscale, logβ / hyperscale) "), I didn't find a definition for it in the Optimiser.jl in Julia's packages. cbed111e69cb391d0d3df445d8d7076

Can you look at it for me? @gaurav-arya

fsfing commented 1 year ago

In addition, can you tell me how the files in the folders params and surdata are generated?

I would appreciate it if you could provide it. @gaurav-arya

gaurav-arya commented 1 year ago

Hi, apologies for the slow reply. I've just made some fixes to the repository to fixed the error you observed, among others. (Note that some fixes are also in the other two repositories, so make sure to update all 3.) Let me know if you have any issues running the example script now!

The params files are handwritten JSON files: different params files give different optimization settings. The surdata folder was generated using the python grcwa package: the RCWA code is unfortunately not currently in an easily reproducible format, but I'd be happy to share it by email. Thanks!